New options control over Animations

[SomeTroglodyte]

Solves #11986 - luxury version

Screwnshots

Predefined sets SelectBox (the "Expert" entry allows controlling each anim individually, the other set all individual options to a preset):

Expert mode:

Notes

• Wording up for discussion
• Choice of predefined sets up for discussion - more of them? Which options on for them?
• Nuke untested, haven't got an advanced game here
• Yes my understanding and testing say it's perfectly fine to leave Gdx.graphics.isContinuousRendering off - or did I miss anything that animates without using Gdx Actions?
• Default on new installs up for discussion
• Migration does not map continuousRendering==false into the new world perfectly - some anims weren't gated at all, to get identical behaviour we would need to create a preset with only the ungated anims on - worth it?

[yairm210]

If anything we want it constantly on
The continuous rendering means redrawing the screen when nothing has changed, this affects the cpu usage considerably

[SomeTroglodyte]

https://libgdx.com/wiki/graphics/continuous-and-non-continuous-rendering
https://github.com/libgdx/libgdx/blob/master/backends/gdx-backend-lwjgl3/src/com/badlogic/gdx/backends/lwjgl3/Lwjgl3Window.java#L404

From that, no, we have no real-time requirements, so we can do with rendering only when there's a reason to - meaning off.

[yairm210]

Right right
Got confused not sure why

[AdityaMH]

Use "custom" instead "expert"?

[yairm210]

After vacillating over this, I think this is overcomplexity no one needs.
There should be one big 'disable animation' setting.

[SomeTroglodyte]

After vacillating over this, I think this is overcomplexity no one needs.

Yes I get that. Though an all-or-nothing would not answer #11986 as I understand it.

By the way - that movement animation is cool, but I had to resist the urge to recode it so embarcation/landing morphs the sprite from ship to land unit and vice versa... Also, it tends to be missed if auto unit cycle yanks away the view...

[SomeTroglodyte]

Use "custom" instead "expert"?

Yup, but the "Some" offer is an even worse choice of wording...

[hippie68]

The pull request works well. I think disabling all animations saves battery life on my laptop.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.