Relations via array #375
Merged
Relations via array #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tigrov
commented
Jul 7, 2024
Tigrov
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues | #362 |
…refactor-populateRelation
# Conflicts: # tests/Driver/Pgsql/ActiveRecordTest.php
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
============================================
+ Coverage 87.30% 87.42% +0.11%
- Complexity 597 598 +1
============================================
Files 17 17
Lines 1410 1423 +13
============================================
+ Hits 1231 1244 +13
Misses 179 179 ☔ View full report in Codecov by Sentry. |
# Conflicts: # tests/ActiveRecordTest.php
vjik
reviewed
Jul 12, 2024
| $attribute = reset($attributes); | ||
|
|
||
| match ($this->getARInstance()->columnType($attribute)) { | ||
| 'array' => $this->andWhere(new ArrayOverlapsCondition($attribute, $values)), |
There was a problem hiding this comment.
Should we add constant TYPE_ARRAY to SchemaInterface in Yii DB?
There was a problem hiding this comment.
Yes, plan to move TYPE_ARRAY and TYPE_BIT from db-pgsql to db package. After it can be replaced to the constant.
samdark
reviewed
Jul 12, 2024
Co-authored-by: Sergei Predvoditelev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.