Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename $attributes to $properties #386

Merged
merged 12 commits into from
Sep 16, 2024
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 11, 2024

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues #343, partially #358

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 84.03756% with 34 lines in your changes missing coverage. Please review.

Project coverage is 84.99%. Comparing base (05942a1) to head (70a4cac).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/AbstractActiveRecord.php 91.05% 11 Missing ⚠️
src/Trait/ArrayAccessTrait.php 0.00% 11 Missing ⚠️
src/Trait/TransactionalTrait.php 0.00% 6 Missing ⚠️
src/ActiveRelationTrait.php 93.93% 2 Missing ⚠️
src/Trait/ArrayIteratorTrait.php 0.00% 2 Missing ⚠️
src/Trait/MagicPropertiesTrait.php 90.90% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #386      +/-   ##
============================================
- Coverage     85.32%   84.99%   -0.33%     
+ Complexity      595      587       -8     
============================================
  Files            17       17              
  Lines          1417     1406      -11     
============================================
- Hits           1209     1195      -14     
- Misses          208      211       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/create-model.md Outdated Show resolved Hide resolved
docs/create-model.md Outdated Show resolved Hide resolved
src/AbstractActiveRecord.php Outdated Show resolved Hide resolved
src/AbstractActiveRecord.php Outdated Show resolved Hide resolved
src/ActiveRecord.php Outdated Show resolved Hide resolved
@Tigrov Tigrov merged commit 5c4151d into master Sep 16, 2024
28 of 30 checks passed
@Tigrov Tigrov deleted the rename-attributes-to-properties branch September 16, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants