Deprecatre ZClient.request method #3154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshith257
requested review from
jdegoes,
vigoo and
987Nabil
as code owners
varshith257
commented
Sep 19, 2024
| client <- ZIO.serviceWith[Client](_.batched) | ||
| chunk <- client.request(request).flatMap(_.body.asChunk) | ||
| } yield FormField.binaryField(name, chunk, mediaType) | ||
| @nowarn("cat=deprecation") |
There was a problem hiding this comment.
@987Nabil Any suggestions here?
I have supplied Scope explicitly with Client with Scope' and also tried wrapping up req in ZIO.scoped` by using streaming/batched appropriately wherever needed but it throwing compile error of not providing Scope.
varshith257
commented
Sep 19, 2024
| URL(Path.empty, Location.Absolute(Scheme.HTTP, "localhost", Some(port))), | ||
| ) | ||
| .batched @@ ZClientAspect.followRedirects(2)((resp, message) => ZIO.logInfo(message).as(resp)) | ||
| response <- client.request(Request.get(URL.empty / "redirect")) |
varshith257
force-pushed
the
deprecate-3.0
branch
from
a61c8dc
to
279af33
Compare
|
@987Nabil Any suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #3133
fixes #3133