Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update and sandardize implementation of packages, in sync with spack update #480

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
fad8028
Update GitLab CI content to match Adrien's RAJA PR
rhornung67 Aug 30, 2024
1c96029
Update files used in GitLab CI
rhornung67 Aug 30, 2024
1e1535c
Update RAJA
adrienbernede Sep 4, 2024
5676a48
Update lassen jobs w.r.t. changes in radiuss-spack-configs
adrienbernede Sep 18, 2024
5896fc5
Merge branch 'develop' into task/rhornung67/update-ci-toolchains
adrienbernede Sep 18, 2024
ea7a9de
Update and standardize RADIUSS packages
adrienbernede Sep 18, 2024
5d0fcd1
build_and_test.sh: allow to control whether or not to push to registry
adrienbernede Sep 19, 2024
77cf546
From RAJA: Update RSC with fixes
adrienbernede Sep 19, 2024
3ee1f8f
Fix package name
adrienbernede Sep 19, 2024
99dd23d
Update RAJA
adrienbernede Sep 25, 2024
6a82d52
Fix Spack branch name
adrienbernede Sep 25, 2024
c06f8c8
From RAJA: From RSC: Add missing sycl variant to RAJAPerf and fix c++…
adrienbernede Sep 25, 2024
f7653e1
Fix tests variant value in sycl spec
adrienbernede Sep 26, 2024
a27dcfe
Turn off openmp support in sycl job on corona (same as RAJA CI)
adrienbernede Sep 26, 2024
e3267f7
turn off benchmarks
adrienbernede Sep 26, 2024
aae34ed
Allow failure of sycl job on corona for now
adrienbernede Sep 26, 2024
9caaef0
Merge branch 'develop' into woptim/spack-update
adrienbernede Sep 30, 2024
98e70e4
From RAJA: From RSC: RAJAPerf: Fix CMake variable for sycl support
adrienbernede Oct 1, 2024
83e4124
Update Spack ref (waiting for next snapshot tag)
adrienbernede Oct 1, 2024
b379712
Update RSC to main
adrienbernede Oct 4, 2024
460a946
From RAJA: Update RAJA and Update RSC to main
adrienbernede Oct 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .gitlab/jobs/corona.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
# ${PROJECT_<MACHINE>_DEPS} in the extra jobs. There is no reason not to fully
# describe the spec here.

# With GitLab CI, included files cannot be empty.
variables:
INCLUDED_FILE_CANNOT_BE_EMPTY: "True"
clang_19_0_0_sycl_gcc_10_3_1_rocmcc_5_7_1_hip:
variables:
SPEC: " ~shared +sycl ~openmp %clang@=19.0.0 cxxflags==\"-w -fsycl -fsycl-unnamed-lambda -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx906\" ^blt@develop"
MODULE_LIST: "rocm/5.7.1"
extends: .job_on_corona
allow_failure: true
36 changes: 22 additions & 14 deletions .gitlab/jobs/lassen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,7 @@
# We keep ${PROJECT_<MACHINE>_VARIANTS} and ${PROJECT_<MACHINE>_DEPS} So that
# the comparison with the original job is easier.

# Overriding shared spec: Longer allocation + extra flags
xl_2022_08_19_gcc_8_3_1_cuda_11_2_0:
variables:
SPEC: "${PROJECT_LASSEN_VARIANTS} +cuda cxxflags==\"-qthreaded -std=c++14 -O3 -qstrict -qxlcompatmacros -qlanglvl=extended0x -qalias=noansi -qhot -qpic -qsmp=omp -qsuppress=1500-029 -qsuppress=1500-036\" %xl@=16.1.1.12.gcc.8.3.1 ^[email protected]+allow-unsupported-compilers ${PROJECT_LASSEN_DEPS}"
MODULE_LIST: "cuda/11.2.0"
LASSEN_JOB_ALLOC: "1 -W 60 -q pci"
extends: .job_on_lassen

# No jobs overridden

############
# Extra jobs
Expand All @@ -36,7 +29,7 @@ xl_2022_08_19_gcc_8_3_1_cuda_11_2_0:

gcc_8_3_1:
variables:
SPEC: " ~shared +openmp %gcc@=8.3.1 ${PROJECT_LASSEN_DEPS}"
SPEC: " ~shared +openmp %gcc@=8.3.1 ^blt@develop"
extends: .job_on_lassen

gcc_8_3_1_cuda_11_5_0_ats_disabled:
Expand Down Expand Up @@ -69,8 +62,23 @@ clang_13_0_1_libcpp:
# LSAN_OPTIONS: "suppressions=${CI_PROJECT_DIR}/tpl/RAJA/suppressions.asan"
# extends: .job_on_lassen

# Activated in RAJA, but we don't use desul atomics here
#gcc_8_3_1_cuda_10_1_168_desul_atomics:
# variables:
# SPEC: "+openmp +cuda +desul %gcc@=8.3.1 cuda_arch=70 cuda_arch=70 ^[email protected]+allow-unsupported-compilers ${PROJECT_LASSEN_DEPS}"
# extends: .job_on_lassen
clang_16_0_6_ibm_omptarget:
variables:
SPEC: " ~shared +openmp +omptarget %clang@=16.0.6.ibm.gcc.8.3.1 ^blt@develop"
ON_LASSEN: "OFF"
extends: .job_on_lassen

xl_2022_08_19_gcc_8_3_1_cuda_11_2_0:
variables:
SPEC: " ~shared +openmp cuda_arch=70 +cuda cxxflags==\"-qthreaded -std=c++14 -O3 -qstrict -qxlcompatmacros -qlanglvl=extended0x -qalias=noansi -qhot -qpic -qsmp=omp -qsuppress=1500-029 -qsuppress=1500-036\" %xl@=16.1.1.12.gcc.8.3.1 ^[email protected]+allow-unsupported-compilers ^blt@develop"
MODULE_LIST: "cuda/11.2.0"
LASSEN_JOB_ALLOC: "1 -W 60 -q pci"
extends: .job_on_lassen

xl_2023_06_28_gcc_11_2_1_cuda_11_8_0:
variables:
SPEC: " ~shared +openmp cuda_arch=70 +cuda cxxflags==\"-qthreaded -std=c++14 -O3 -qstrict -qxlcompatmacros -qlanglvl=extended0x -qalias=noansi -qhot -qpic -qsmp=omp -qsuppress=1500-029 -qsuppress=1500-036\" %xl@=16.1.1.14.cuda.11.8.0.gcc.11.2.1 ^[email protected]+allow-unsupported-compilers ^blt@develop"
MODULE_LIST: "cuda/11.8.0"
LASSEN_JOB_ALLOC: "1 -W 60 -q pci"
extends: .job_on_lassen

5 changes: 0 additions & 5 deletions .gitlab/jobs/poodle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ gcc_10_3_1:
SPEC: "${PROJECT_POODLE_VARIANTS} +omptask %gcc@=10.3.1 ${PROJECT_POODLE_DEPS}"
extends: .job_on_poodle

intel_19_1_2_gcc_10_3_1:
variables:
SPEC: "${PROJECT_POODLE_VARIANTS} %intel@=19.1.2.gcc.10.3.1 ${PROJECT_POODLE_DEPS}"
extends: .job_on_poodle

intel_2022_1_0:
variables:
SPEC: "${PROJECT_POODLE_VARIANTS} %intel@=2022.1.0 ${PROJECT_POODLE_DEPS}"
Expand Down
6 changes: 0 additions & 6 deletions .gitlab/jobs/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ gcc_10_3_1:
RUBY_BUILD_AND_TEST_JOB_ALLOC: "--time=60 --nodes=1"
extends: .job_on_ruby

intel_19_1_2_gcc_10_3_1:
variables:
SPEC: "${PROJECT_RUBY_VARIANTS} %intel@=19.1.2.gcc.10.3.1 ${PROJECT_RUBY_DEPS}"
RUBY_BUILD_AND_TEST_JOB_ALLOC: "--time=40 --nodes=1"
extends: .job_on_ruby

intel_2022_1_0:
variables:
SPEC: "${PROJECT_RUBY_VARIANTS} %intel@=2022.1.0 ${PROJECT_RUBY_DEPS}"
Expand Down
8 changes: 4 additions & 4 deletions .gitlab/jobs/tioga.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@
# ${PROJECT_<MACHINE>_DEPS} in the extra jobs. There is no reason not to fully
# describe the spec here.

rocmcc_6_1_1_hip_openmp:
rocmcc_6_2_0_hip_openmp:
variables:
SPEC: "~shared +rocm +openmp amdgpu_target=gfx90a %rocmcc@=6.1.1 ^hip@6.1.1 ^blt@develop"
SPEC: "~shared +rocm +openmp amdgpu_target=gfx90a %rocmcc@=6.2.0 ^hip@6.2.0 ^blt@develop"
extends: .job_on_tioga

rocmcc_6_1_1_hip_openmp_mpi:
rocmcc_6_2_0_hip_openmp_mpi:
variables:
SPEC: "~shared +rocm +openmp +mpi amdgpu_target=gfx90a %rocmcc@=6.1.1 ^hip@6.1.1 ^blt@develop"
SPEC: "~shared +rocm +openmp +mpi amdgpu_target=gfx90a %rocmcc@=6.2.0 ^hip@6.2.0 ^blt@develop"
extends: .job_on_tioga
allow_failure: true
4 changes: 2 additions & 2 deletions .uberenv_config.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"package_name" : "raja_perf",
"package_name" : "raja-perf",
"package_version" : "develop",
"package_final_phase" : "initconfig",
"package_source_dir" : "../..",
"spack_url": "https://github.com/spack/spack.git",
"spack_branch": "develop-2024-05-26",
"spack_commit": "d7f5dbaf8911387d6c38035f0d508702ee71b03a",
"spack_activate" : {},
"spack_configs_path": "tpl/RAJA/scripts/radiuss-spack-configs",
"spack_packages_path": "tpl/RAJA/scripts/radiuss-spack-configs/packages",
Expand Down
4 changes: 3 additions & 1 deletion scripts/gitlab/build_and_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ job_unique_id=${CI_JOB_ID:-""}
use_dev_shm=${USE_DEV_SHM:-true}
spack_debug=${SPACK_DEBUG:-false}
debug_mode=${DEBUG_MODE:-false}
push_to_registry=${PUSH_TO_REGISTRY:-true}

raja_version=${UPDATE_RAJA:-""}
sys_type=${SYS_TYPE:-""}
Expand Down Expand Up @@ -59,6 +60,7 @@ then
echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
use_dev_shm=false
spack_debug=true
push_to_registry=false
fi

if [[ -n ${module_list} ]]
Expand Down Expand Up @@ -149,7 +151,7 @@ then
timed_message "Spack build of dependencies"
${uberenv_cmd} --skip-setup-and-env --spec="${spec}" ${prefix_opt} ${upstream_opt}

if [[ -n ${ci_registry_token} && ${debug_mode} == false ]]
if [[ -n ${ci_registry_token} && ${push_to_registry} == true ]]
then
timed_message "Push dependencies to buildcache"
${spack_cmd} -D ${spack_env_path} buildcache push --only dependencies gitlab_ci
Expand Down
2 changes: 1 addition & 1 deletion tpl/RAJA
Submodule RAJA updated 59 files
+25 −0 .github/ISSUE_TEMPLATE/bug_report.md
+22 −0 .github/ISSUE_TEMPLATE/feature_request.md
+74 −0 .github/workflows/build.yml
+5 −5 .gitlab/custom-jobs-and-variables.yml
+3 −3 .gitlab/jobs/corona.yml
+10 −17 .gitlab/jobs/lassen.yml
+9 −16 .gitlab/jobs/poodle.yml
+9 −14 .gitlab/jobs/ruby.yml
+16 −5 .gitlab/jobs/tioga.yml
+1 −1 .uberenv_config.json
+2 −1 CMakeLists.txt
+118 −74 Dockerfile
+8 −3 README.md
+14 −26 azure-pipelines.yml
+13 −2 benchmark/CMakeLists.txt
+346 −0 benchmark/benchmark-atomic.cpp
+218 −0 benchmark/raja_view_blur.cpp
+2 −1 docs/conf.py
+2 −1 docs/index.rst
+16 −22 docs/sphinx/dev_guide/build_configurations.rst
+84 −37 docs/sphinx/dev_guide/ci.rst
+136 −88 docs/sphinx/dev_guide/ci_tasks.rst
+4 −4 docs/sphinx/dev_guide/contributing.rst
+1 −1 docs/sphinx/user_guide/feature/policies.rst
+9 −1 docs/sphinx/user_guide/getting_started.rst
+8 −0 docs/sphinx/user_guide/tutorial.rst
+0 −5 exercises/dot-product.cpp
+1 −6 exercises/dot-product_solution.cpp
+0 −5 exercises/vector-addition.cpp
+1 −6 exercises/vector-addition_solution.cpp
+14 −0 host-configs/lc-builds/toss4/clang_X_asan.cmake
+14 −0 host-configs/lc-builds/toss4/clang_X_ubsan.cmake
+19 −0 include/RAJA/pattern/launch/launch_core.hpp
+3 −2 include/RAJA/policy/cuda/launch.hpp
+3 −0 include/RAJA/policy/openmp/launch.hpp
+6 −10 include/RAJA/policy/sycl/MemUtils_SYCL.hpp
+6 −13 include/RAJA/policy/sycl/reduce.hpp
+3 −2 include/RAJA/util/math.hpp
+3 −1 scripts/gitlab/build_and_test.sh
+1 −1 scripts/lc-builds/blueos_clang.sh
+1 −1 scripts/lc-builds/blueos_clang_omptarget.sh
+1 −1 scripts/lc-builds/blueos_clangcuda.sh
+1 −1 scripts/lc-builds/blueos_gcc.sh
+1 −1 scripts/lc-builds/blueos_nvcc_clang.sh
+1 −1 scripts/lc-builds/blueos_nvcc_gcc.sh
+1 −1 scripts/lc-builds/blueos_nvcc_xl.sh
+1 −1 scripts/lc-builds/blueos_pgi.sh
+1 −1 scripts/lc-builds/blueos_xl.sh
+1 −1 scripts/lc-builds/blueos_xl_omptarget.sh
+1 −1 scripts/lc-builds/corona_sycl.sh
+1 −1 scripts/lc-builds/toss4_amdclang.sh
+1 −1 scripts/lc-builds/toss4_amdclang_asan.sh
+57 −0 scripts/lc-builds/toss4_clang_san.sh
+1 −1 scripts/lc-builds/toss4_icpc-classic.sh
+2 −2 scripts/lc-builds/toss4_icpx.sh
+1 −1 scripts/radiuss-spack-configs
+0 −14 src/MemUtils_SYCL.cpp
+1 −1 tpl/camp
+1 −1 tpl/desul
Loading