Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/rhornung67/fir memory issue #481

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Bugfix/rhornung67/fir memory issue #481

merged 2 commits into from
Sep 27, 2024

Conversation

rhornung67
Copy link
Member

Summary

  • This PR is a bugfix.
  • It fixes the CMake version in the SYCL build script. What was there does not exist on corona.
  • Fixes device memory issue in SYCL variants of FIR kernel so now tests pass.

@rhornung67 rhornung67 mentioned this pull request Sep 27, 2024
Open
5 tasks
@rhornung67 rhornung67 merged commit 186d419 into develop Sep 27, 2024
24 checks passed
@rhornung67 rhornung67 deleted the bugfix/rhornung67/FIR-memory-issue branch September 27, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adayton1 adayton1 adayton1 approved these changes

@MrBurmark MrBurmark Awaiting requested review from MrBurmark

@artv3 artv3 Awaiting requested review from artv3

@rchen20 rchen20 Awaiting requested review from rchen20

@adrienbernede adrienbernede Awaiting requested review from adrienbernede

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhornung67 @adayton1