PlayerData changes #2946
Open
PlayerData changes #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new constructor with a parameter that is responsible for installing TShock items into inventory. The `TSPlayer` parameter was not used, so I labeled the constructor obsolete.
Removed the ability to call a method when a slot less than 0 is specified. Added an overload that takes `NetItem` in parameters.
QuiCM
previously approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the PlayerData constructor has a
TSPlayerparameter, but it's not used, so I marked it obsolete and added a new constructor that has theincludingStarterInventoryparameter. Thebool includingStarterInventoryparameter is needed to add items from the SSC config.In the same way, I noticed that there is a check for the maximum slot (
if (slot > (this.inventory.Length - 1))), but no check for the minimum:slot < 0. So I changed the condition in theStoreSlotmethod to:if (slot > (this.inventory.Length - 1) || slot < 0)Added overloaded "StoreSlot" method that takes the NetItem parameter.