Remove Handle<T> trait implementations that are dependent on Component
#15749
+12
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-blackbird
added
A-Rendering
IceSentry
reviewed
Oct 8, 2024
| pub type RenderMaterialInstances<M> = ExtractedInstances<AssetId<M>>; | ||
| /// Stores all extracted instances of a [`Material`] in the render world. | ||
| #[derive(Resource, Deref, DerefMut)] | ||
| pub struct RenderMaterialInstances<M: Material>(pub EntityHashMap<AssetId<M>>); |
There was a problem hiding this comment.
Am I missing something? This doesn't seem to be used anywhere.
There was a problem hiding this comment.
You must be, it's being use in quite a few places :)
None of them show up in the diff because it's API is exactly what it was, in case that's where you were looking
alice-i-cecile
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Componenttrait impl fromHandle<T>#15716Handle<T>being aComponentSolution
ExtractComponenttrait implementation forHandle<T>ExtractInstancetrait implementation forAssetIdExtractInstancetrait wasn't used, theAssetIds were being stored inside ofExtractedInstanceswhich has anExtractInstancetrait bound on its contents.I've upgraded the
RenderMaterialInstancestype alias to be its own resource, identical toExtractedInstances<AssetId<M>>to get around that with minimal breakage.Testing
Tested
many_cubes, rendering did not explode