Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delayed notification of clients about client published topic [ROS 1] #274

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ros1_foxglove_bridge/src/ros1_foxglove_bridge_nodelet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,8 @@ class FoxgloveBridge : public nodelet::Nodelet {
ROS_INFO("Client %s is advertising \"%s\" (%s) on channel %d",
_server->remoteEndpointString(clientHandle).c_str(), channel.topic.c_str(),
channel.schemaName.c_str(), channel.channelId);
// Trigger topic discovery so other clients are immediately informed about this new topic.
updateAdvertisedTopics();
} else {
const auto errMsg =
"Failed to create publisher for topic " + channel.topic + "(" + channel.schemaName + ")";
Expand Down