Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo data into repository #12

Merged
merged 3 commits into from
May 6, 2024

Conversation

JarettBakerDunn
Copy link
Contributor

I copied the data from https://geodynamics.org/resources/mineos/supportingdocs into the repository in the directory demo-data. I also removed the submodule DEMO folder, I hope that won't make any problems.

@JarettBakerDunn
Copy link
Contributor Author

Should I add the manual PDF from geodynamics.org to the repository as well? Currently the manual is only available in Lyx files in the repository.

@ljhwang
Copy link

ljhwang commented Apr 12, 2024

I recall that we made a decision NOT to include the pdfs so as not to clutter up the repos. The rationale being that it could always be built.

If we continue to exclude, then the README will need to be updated and perhaps point to https://geodynamics.org/resources/mineos.

readme points to https://geodynamics.org/resources/mineos for the manual, rather than docs/manual.pdf, which isn't present in the repository anymore.
@gassmoeller
Copy link
Member

Thanks for figuring this out, this should fix issues #9 and #11.
But maybe you could put the data into a folder named DEMO instead of demo-data? That way all old references to the DEMO submodule would continue to work? Or was the data always in a directory called demo-data?

@JarettBakerDunn
Copy link
Contributor Author

@gassmoeller I deleted the DEMO folder because it prevented me from cloning the repository because I couldn't reach the submodule. I don't have much experience with git submodules, so I'm not sure the best way to approach this. It looks like I could unlink the DEMO folder from the submodule and rename the demo-data folder to the original name, which was DEMO. But I don't know if unlinking the directory from the submodule would stop the old references from working.

@ljhwang
Copy link

ljhwang commented Apr 17, 2024

I only see the directory DEMO referred to once and that is in the manual. I don't think you will break anything!

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this is what I meant with my previous comment. Thanks!

@gassmoeller gassmoeller merged commit 04a992a into geodynamics:master May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants