-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo data into repository #12
Conversation
Should I add the manual PDF from geodynamics.org to the repository as well? Currently the manual is only available in Lyx files in the repository. |
I recall that we made a decision NOT to include the pdfs so as not to clutter up the repos. The rationale being that it could always be built. If we continue to exclude, then the README will need to be updated and perhaps point to https://geodynamics.org/resources/mineos. |
readme points to https://geodynamics.org/resources/mineos for the manual, rather than docs/manual.pdf, which isn't present in the repository anymore.
@gassmoeller I deleted the DEMO folder because it prevented me from cloning the repository because I couldn't reach the submodule. I don't have much experience with git submodules, so I'm not sure the best way to approach this. It looks like I could unlink the DEMO folder from the submodule and rename the demo-data folder to the original name, which was DEMO. But I don't know if unlinking the directory from the submodule would stop the old references from working. |
I only see the directory DEMO referred to once and that is in the manual. I don't think you will break anything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, this is what I meant with my previous comment. Thanks!
I copied the data from https://geodynamics.org/resources/mineos/supportingdocs into the repository in the directory demo-data. I also removed the submodule DEMO folder, I hope that won't make any problems.