Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add an implementation of ReadAsync to ZipAESStream #576

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Feb 14, 2021

refs #572

Add an implementation of ReadAsync to ZipAESStream, with associated StreamUtils change and a copy/pasted unit test (that currently fails on .NETCore 3.1 due to #572).

WIP because:

  1. There is still a bunch of duplication between ReadAndTransform/ReadAndTransformAsync, and the copy/pasted signature of TransformFromSlideBuffer doesn't feel ideal.

  2. Looking at ZipFile.GetInputStream a bit more, I don't think it will actually do async reads from the base stream unless PartialInputStream is given some async support as well, so the current code might not actually be any 'more' async that just making ReadAsync call Read synchrounously and then returning the result.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@Numpsy
Copy link
Contributor Author

Numpsy commented Feb 14, 2021

just making ReadAsync call Read synchrounously and then returning the result

which would be the fastest change if we want a fix ASAP, but not as nice as a real async impl, which fits in more with the other async supporting changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant