Make stream_to accept optional<string_view>.
#597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #596. It'd be nice to support each of `optional`, `shared_ptr`, `unique_ptr`, and potentially other smart pointer types for each of these string types. But doing that without C++20's "concepts" is going to be a little hairy.
Extends special-case support for `string_view` etc. in `stream_to` to optional values as well. This is ugly. I want to do better. But it looks like that'll work a lot better with C++20.
Getting some warnings that look wholly unrelated to my changes, and in fact seem to be completely internal to the library implementation.
I can't reproduce this compile warning in a `debian:testing` container on my own machine. So, just in case the problem is a caching effect, let's try a newer Debian version.
|
Please apply a similar fix to #694 694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #596.
Supports
std::optional,std::shared_ptr, andstd::unique_ptrofstd::string,std::string_view, andpqxx::zview. It's not the prettiest code, and some day I hope to generalise this stuff using C++20's Concepts.