-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stream_to
accept optional<string_view>
.
#597
Merged
Merged
Commits on Aug 31, 2022
-
Make
stream_to
acceptoptional<string_view>
.Fixes #596. It'd be nice to support each of `optional`, `shared_ptr`, `unique_ptr`, and potentially other smart pointer types for each of these string types. But doing that without C++20's "concepts" is going to be a little hairy.
Configuration menu - View commit details
-
Copy full SHA for 490ab47 - Browse repository at this point
Copy the full SHA 490ab47View commit details
Commits on Sep 1, 2022
-
Test, and support smart pointers.
Extends special-case support for `string_view` etc. in `stream_to` to optional values as well. This is ugly. I want to do better. But it looks like that'll work a lot better with C++20.
Configuration menu - View commit details
-
Copy full SHA for 95c727d - Browse repository at this point
Copy the full SHA 95c727dView commit details -
Getting some warnings that look wholly unrelated to my changes, and in fact seem to be completely internal to the library implementation.
Configuration menu - View commit details
-
Copy full SHA for 6e32c53 - Browse repository at this point
Copy the full SHA 6e32c53View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1cef04 - Browse repository at this point
Copy the full SHA f1cef04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ebfdf2 - Browse repository at this point
Copy the full SHA 0ebfdf2View commit details -
I can't reproduce this compile warning in a `debian:testing` container on my own machine. So, just in case the problem is a caching effect, let's try a newer Debian version.
Configuration menu - View commit details
-
Copy full SHA for 6e36ad3 - Browse repository at this point
Copy the full SHA 6e36ad3View commit details
Commits on Sep 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8ddec3a - Browse repository at this point
Copy the full SHA 8ddec3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd9848a - Browse repository at this point
Copy the full SHA cd9848aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3c6596 - Browse repository at this point
Copy the full SHA a3c6596View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.