Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stream_to accept optional<string_view>. #597

Merged
merged 9 commits into from
Sep 2, 2022
Merged

Commits on Aug 31, 2022

  1. Make stream_to accept optional<string_view>.

    Fixes #596.
    
    It'd be nice to support each of `optional`, `shared_ptr`, `unique_ptr`,
    and potentially other smart pointer types for each of these string
    types.  But doing that without C++20's "concepts" is going to be a
    little hairy.
    jtv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    490ab47 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Test, and support smart pointers.

    Extends special-case support for `string_view` etc. in `stream_to` to
    optional values as well.
    
    This is ugly.  I want to do better.  But it looks like that'll work a
    lot better with C++20.
    jtv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    95c727d View commit details
    Browse the repository at this point in the history
  2. Try Debian stable.

    Getting some warnings that look wholly unrelated to my changes, and in
    fact seem to be completely internal to the library implementation.
    jtv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    6e32c53 View commit details
    Browse the repository at this point in the history
  3. Back to Debian testing.

    jtv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    f1cef04 View commit details
    Browse the repository at this point in the history
  4. Add TODO.

    jtv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    0ebfdf2 View commit details
    Browse the repository at this point in the history
  5. Try Debian unstable.

    I can't reproduce this compile warning in a `debian:testing` container
    on my own machine.  So, just in case the problem is a caching effect,
    let's try a newer Debian version.
    jtv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    6e36ad3 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Okay, apt upgrade then?

    jtv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    8ddec3a View commit details
    Browse the repository at this point in the history
  2. Try building with clang for now.

    jtv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    cd9848a View commit details
    Browse the repository at this point in the history
  3. Pass language version for clang.

    jtv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a3c6596 View commit details
    Browse the repository at this point in the history