Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go sync/atomic instead of go.uber.org/atomic #2777

Merged
merged 9 commits into from
Aug 2, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Aug 2, 2023

Since Go 1.19, new type for sync/atomic was introduced like Int32 and Bool so it is possible to replace go.uber.org/atomic.

This patch makes the change.

Release Note

NONE

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release labels Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (7b50f3c) 81.75% compared to head (f6dcc59) 81.79%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2777      +/-   ##
==========================================
+ Coverage   81.75%   81.79%   +0.03%     
==========================================
  Files         167      167              
  Lines       10201    10204       +3     
==========================================
+ Hits         8340     8346       +6     
+ Misses       1614     1612       -2     
+ Partials      247      246       -1     
Files Changed Coverage Δ
metrics/metrics.go 83.33% <100.00%> (ø)
profiling/server.go 75.92% <100.00%> (+1.41%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krsna-m
Copy link
Contributor

krsna-m commented Aug 2, 2023

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvmware, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@knative-prow knative-prow bot merged commit c11003a into knative:main Aug 2, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants