-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#458 removal of gaian/ranger/derby/virtualization connectors/services #5314
Conversation
Signed-off-by: Nigel Jones <[email protected]>
It is ok to remove the governance server modules:
Removing obsolete admin services structures (SecurityOfficerConfig, SecuritySyncConfig, VirtualizationConfig, Data PlatformServicesConfig, DiscoveryEngineServices, StewardshipEngineServicesConfig) could break backward compatibility - however I would be in favour of the clean up since they have been deprecated for a while. If we remove these structures, and they are included in a server's configuration document then the first time our code reads the JSON and sotres it, these sections will be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to update ContentOrganization.md in top level directory
open-metadata-implementation/adapters/open-connectors/governance-daemon-connectors/README.md
Outdated
Show resolved
Hide resolved
open-metadata-implementation/adapters/open-connectors/data-store-connectors/README.md
Show resolved
Hide resolved
.../org/odpi/openmetadata/adminservices/configuration/properties/AdminServicesConfigHeader.java
Outdated
Show resolved
Hide resolved
...org/odpi/openmetadata/adminservices/configuration/registration/AccessServiceDescription.java
Outdated
Show resolved
Hide resolved
|
@mandy-chessell many thanks for the review |
@lpalashevski @mandy-chessell When trying to remove data platform OMAS, I note that the cassandra metadata extractor module is dependent on data platform OMAS. I need to either
|
Signed-off-by: Nigel Jones <[email protected]>
AdditionalChanges
Having reviewed the changes some more I propose:
|
Signed-off-by: Nigel Jones <[email protected]>
As a TBD I will update the release notes once we're generally happy with the proposal (likely in this PR) |
These services have already been folded into the integration services running in the intrgration daemon so no longer needed. |
Just noticed an update needed to ContentOrganization.md - removal of governance-engine-plugins under adapters |
Signed-off-by: Nigel Jones <[email protected]>
done. |
Opened up followup items:
|
Now added an initial readme entry for release notes |
Opened #5320 to track gaian reference in Security Officer OMAS |
Signed-off-by: Nigel Jones <[email protected]>
Signed-off-by: Nigel Jones <[email protected]>
@mandy-chessell SecurityManagerEventType.java contains:
(Data Platform has a similar event - but this will be addressed in #5319 most easily) I think this should be removed. There is no other handling of it. However it may be that we want to reuse it in future? @mandy-chessell Can you also clarify the requirement to leave Information View OMAS in the AccessServiceDescription.java file? (presuming the same logic would apply to data platform omas in future). We also have SECURITY_OFFICER_SERVICES & SECURITY_SYNC_SERVICES where the same question applies (GovernanceServicesDescription.java) |
Some other observations that I'm looking for insight on. None directly affect this PR, and I think all relate to the base support for security tags which is seen across many interfaces & beans.
|
@yevgenmar I note that in AnalyticsArtifactHandler.java in analytics modeling, you comment 'Note: use resolver from InformationView asset'. From the code I presume you mean 'from Analytics Asset' or similar. I can update if needed (v. minor) |
Signed-off-by: Nigel Jones <[email protected]>
Signed-off-by: Nigel Jones <[email protected]>
Any more comments on this? I am going to propose it's inclusion on the team call 2021-06-08 unless I get multiple positive reviews before then |
� Conflicts: � open-metadata-implementation/admin-services/admin-services-api/src/main/java/org/odpi/openmetadata/adminservices/configuration/properties/AdminServicesConfigHeader.java � open-metadata-implementation/admin-services/admin-services-api/src/main/java/org/odpi/openmetadata/adminservices/configuration/properties/OMAGServerConfig.java � open-metadata-implementation/admin-services/admin-services-server/src/main/java/org/odpi/openmetadata/adminservices/classifier/ServerTypeClassifier.java
Signed-off-by: Nigel Jones <[email protected]>
Approved in developer call 2021-06-08 |
Signed-off-by: Nigel Jones [email protected]
Still to consider
Open for review....
Fixes: #458