-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8311530: Deprecate jdk.jsobject module for removal #20555
base: master
Are you sure you want to change the base?
8311530: Deprecate jdk.jsobject module for removal #20555
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@kevinrushforth The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label client |
@kevinrushforth |
The GHA run shows a spurious failure in macOS (a network timeout cloning the repo). I'll rerun it with no changes to my branch. |
Webrevs
|
8311530: Deprecate jdk.jsobject module for removal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll review the CSR when its ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to make jdk.jsobject an upgradeable module looks right.
I was initially surprised by the wording "will be delivered with JavaFX" but after playing with a few alternatives I concluded that what we have is okay.
Thanks.
Thanks for checking. My testing primarily focused on this aspect of the change, so it's pretty well tested.
Yeah, I tried a few variants and couldn't come up with anything better. |
@kevinrushforth Is the CSR on your list to write? |
Yes, this was on hold for a couple weeks; I plan to write the CSR this week. |
I've created the CSRs for both the this PR and openjdk/jfx#1529. |
Deprecate the
jdk.jsobject
module for removal from the JDK, and ship it with JavaFX instead.See JDK-8337280 / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios.
This PR does two things:
jdk.jsobject
module for removal; the javadoc indicates that the module will be delivered with JavaFXjdk.jsobject
an upgradeable module, which will facilitate the transition by allowing the version of the module shipped with JavaFX to be used in favor of the deprecated module in the JDK itself.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20555/head:pull/20555
$ git checkout pull/20555
Update a local copy of the PR:
$ git checkout pull/20555
$ git pull https://git.openjdk.org/jdk.git pull/20555/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20555
View PR using the GUI difftool:
$ git pr show -t 20555
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20555.diff
Webrev
Link to Webrev Comment