Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311530: Deprecate jdk.jsobject module for removal #20555

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 12, 2024

Deprecate the jdk.jsobject module for removal from the JDK, and ship it with JavaFX instead.

See JDK-8337280 / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios.

This PR does two things:

  1. Deprecates the jdk.jsobject module for removal; the javadoc indicates that the module will be delivered with JavaFX
  2. Makes jdk.jsobject an upgradeable module, which will facilitate the transition by allowing the version of the module shipped with JavaFX to be used in favor of the deprecated module in the JDK itself.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8338250 to be approved

Issues

  • JDK-8311530: Deprecate jdk.jsobject module for removal (Bug - P4)
  • JDK-8338250: Deprecate jdk.jsobject module for removal (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20555/head:pull/20555
$ git checkout pull/20555

Update a local copy of the PR:
$ git checkout pull/20555
$ git pull https://git.openjdk.org/jdk.git pull/20555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20555

View PR using the GUI difftool:
$ git pr show -t 20555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20555.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@kevinrushforth The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build [email protected] core-libs [email protected] csr Pull request needs approved CSR before integration labels Aug 12, 2024
@kevinrushforth
Copy link
Member Author

/label client

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@kevinrushforth
The client label was successfully added.

@kevinrushforth
Copy link
Member Author

The GHA run shows a spurious failure in macOS (a network timeout cloning the repo). I'll rerun it with no changes to my branch.

@kevinrushforth kevinrushforth marked this pull request as ready for review September 5, 2024 21:13
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 5, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2024

Webrevs

github-actions bot pushed a commit to dougxc/openjdk-pr-canary that referenced this pull request Sep 6, 2024
8311530: Deprecate jdk.jsobject module for removal
Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll review the CSR when its ready.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to make jdk.jsobject an upgradeable module looks right.

I was initially surprised by the wording "will be delivered with JavaFX" but after playing with a few alternatives I concluded that what we have is okay.

@kevinrushforth
Copy link
Member Author

Looks good. I'll review the CSR when its ready.

Thanks.

The changes to make jdk.jsobject an upgradeable module looks right.

Thanks for checking. My testing primarily focused on this aspect of the change, so it's pretty well tested.

I was initially surprised by the wording "will be delivered with JavaFX" but after playing with a few alternatives I concluded that what we have is okay.

Yeah, I tried a few variants and couldn't come up with anything better.

@AlanBateman
Copy link
Contributor

@kevinrushforth Is the CSR on your list to write?

@kevinrushforth
Copy link
Member Author

Yes, this was on hold for a couple weeks; I plan to write the CSR this week.

@kevinrushforth
Copy link
Member Author

I've created the CSRs for both the this PR and openjdk/jfx#1529.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build [email protected] client [email protected] core-libs [email protected] csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants