-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337280: Include jdk.jsobject module with JavaFX #1529
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
static { | ||
System.err.println("KCR: JavaFX version of jdk.jsobject loaded"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This debug print statement is there to make it easy to see if the JavaFX version of this class is being loaded. I'll leave it during testing and review, but I'll remove it before the final review.
/reviewers 2 |
@kevinrushforth |
Webrevs
|
settings.gradle
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update to copyright year has been reverted by commit 33355b4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember why I did that, but I'll redo the change to 2024. Thanks.
Old version of classes Should these classes be removed? [1] : https://github.com/openjdk/jfx/tree/jfx23/modules/javafx.web/src/android/java/netscape/javascript |
Mailing list message from Johan Vos on openjfx-dev: Hi Kevin, Thanks for the extensive checks on these scenario's. I believe the scenario - Johan Op do 5 sep 2024 om 23:18 schreef Kevin Rushforth <kcr at openjdk.org>: -------------- next part -------------- |
I'll let @johanvos speak to that. If this is desired, then it's probably best done as a follow-up, since I can't test the Android (or iOS) implementation. |
Yes.
Agreed. I've marked this RFE as needing a release note, and will be sure to clarify this. |
Yes, those can be removed. There is more (ios/android) code that can be removed, or that even should be removed. I'll file a follow-up for this. |
Created https://bugs.openjdk.org/browse/JDK-8339705 for this |
After merging in the latest master yesterday, I discovered that the recently-enabled javac lint warnings and I'm done with my testing, and will switch to creating the CSRs. Reviewers: @arapte @jaybhaskar |
I've created the CSRs for both the this PR and openjdk/jdk#20555. |
Add the
jdk.jsobject
module to JavaFX. This module is currently delivered by the JDK, but will be terminally-deprecated in JDK 24 by JDK-8311530, which is out for review at openjdk/jdk#20555. We therefore plan to start delivering it with JavaFX in JavaFX 24.Testing scenarios
Both JDK and JavaFX for some period of time, so we need to test various scenarios. I built and tested this PR branch with each of the following JDKs:
jdk.jsobject
as a normal, non-upgradable modulejdk.jsobject
as a terminally-deprecated, upgradable modulejdk.jsobject
module, and is therefore a prototype of what will happen in JDK 26 (or later) when it is removed from the JDKI ran a build and test of JavaFX from this PR branch using each of the above JDKs. All tests pass.
I then took the JavaFX artifacts built by JDK 1 (matching how we will deliver this in JavaFX 24), and ran the following additional tests, all of which match my expectations:
RESULT: JDKs 1 and 2 use the
jdk.jsobject
module from the JDK; JDK 3 uses thejdk.jsobject
module from JavaFXRESULT: JDK 1 will fail to launch; JDKs 2 and 3 use the
jdk.jsobject
module from JavaFXRESULT: JDK 1 will fail to link; JDKs 2 and 3 use the
jdk.jsobject
module from JavaFXRESULT: JDKs 1 and 2 will use the
jdk.jsobject
module from the JDK; JDK 3 uses thejdk.jsobject
module from JavaFXI have not verified the maven artifacts, but they are being generated correctly.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1529/head:pull/1529
$ git checkout pull/1529
Update a local copy of the PR:
$ git checkout pull/1529
$ git pull https://git.openjdk.org/jfx.git pull/1529/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1529
View PR using the GUI difftool:
$ git pr show -t 1529
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1529.diff
Webrev
Link to Webrev Comment