Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TLS parameters inside if statements #881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vuldin
Copy link
Member

@vuldin vuldin commented Nov 20, 2023

Small change to move the start of the two TLS sections admin_api_tls and kafka_api_tls into their associated if statement.

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please sign CLA

Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, non blocking.

@@ -165,8 +165,8 @@ redpanda.yaml: |
port: {{ $listener.port }}
{{- end }}
{{- end }}
admin_api_tls:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, nothing will break if this is empty nor if this is left out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is the case, which is surprising to me as it could result in an empty section in the yaml. I'm not sure why disabling TLS works without the change in this PR.

@vuldin
Copy link
Member Author

vuldin commented Dec 5, 2023

I've signed the CLA, but Github is now thinking showing me two CLA notices in this thread and only one is green:

image

@RafalKorepta
Copy link
Contributor

@ivotron Could you help in the problem of CLA boot confusion?

@ivotron
Copy link
Member

ivotron commented Dec 5, 2023

that's a race we've seen elsewhere. fine to ignore since we have that green one

@vuldin vuldin requested a review from chrisseto as a code owner April 11, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants