Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TLS parameters inside if statements #881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move TLS parameters inside if statements #881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/redpanda/templates/_configmap.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ redpanda.yaml: |
port: {{ $listener.port }}
{{- end }}
{{- end }}
admin_api_tls:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, nothing will break if this is empty nor if this is left out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is the case, which is surprising to me as it could result in an empty section in the yaml. I'm not sure why disabling TLS works without the change in this PR.

{{- if (include "admin-internal-tls-enabled" . | fromJson).bool }}
admin_api_tls:
- name: internal
enabled: true
cert_file: /etc/tls/certs/{{ $service.tls.cert }}/tls.crt
Expand Down Expand Up @@ -301,8 +301,8 @@ redpanda.yaml: |
{{- end }}
{{- end }}
{{- end }}
kafka_api_tls:
{{- if (include "kafka-internal-tls-enabled" . | fromJson).bool }}
kafka_api_tls:
- name: internal
enabled: true
cert_file: /etc/tls/certs/{{ $kafkaService.tls.cert }}/tls.crt
Expand Down
Loading