Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fortress packages for Ubuntu Jammy. #153

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Update Fortress packages for Ubuntu Jammy. #153

merged 2 commits into from
Apr 22, 2022

Conversation

nuclearsandwich
Copy link
Contributor

According to the script which scraped packages.osrfoundation.org ogre-2.2 is missing. I know there were plans to make an ogre-next package available upstream in Ubuntu Jammy but I don't think those plans have progressed.

Created using the script in #144

@nuclearsandwich
Update Fortress packages for Ubuntu Jammy.
e5ea24f 
According to the script which scraped packages.osrfoundation.org
ogre-2.2 is missing.
@nuclearsandwich nuclearsandwich self-assigned this Apr 15, 2022
@nuclearsandwich nuclearsandwich mentioned this pull request Apr 15, 2022
Open
@ijnek ijnek mentioned this pull request Apr 16, 2022
Closed
chapulina
chapulina approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All versions LGTM

I know there were plans to make an ogre-next package available upstream in Ubuntu Jammy but I don't think those plans have progressed.

We should be able to use libogre-next-dev from Jammy upstream, no need to pull Ogre from the OSRF repo

j-rivero
j-rivero previously approved these changes Apr 18, 2022
View reviewed changes
j-rivero
j-rivero reviewed Apr 18, 2022
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is complaining about ignition-physics5 source package although it seems to be in the list. Is this a false positive or a known bug in CI?

@j-rivero j-rivero dismissed their stale review April 18, 2022 22:43

found problems on CI

@nuclearsandwich
Copy link
Contributor Author

CI is complaining about ignition-physics5 source package although it seems to be in the list. Is this a false positive or a known bug in CI?

It's present in the config file: https://github.com/ros-infrastructure/reprepro-updater/pull/153/files#diff-ed53c00ca8237f7ba852b561c727fde4295b2d70918e55cfa6afbf12c142fd52R56

But there's a mismatch between the version in the sources and the version in the config / version in the binary-amd64 repository.

Package: ignition-physics5
Format: 3.0 (quilt)
Binary: libignition-physics5-core-dev, libignition-physics5-sdf-dev, libignition-physics5-mesh-dev, libignition-physics5-heightmap-dev, libignition-physics5, libignition-physics5-dartsim-dev, libignition-physics5-dartsim, libignition-physics5-tpe-dev, libignition-physics5-tpe, libignition-physics5-tpelib-dev, libignition-physics5-tpelib, libignition-physics5-bullet-dev, libignition-physics5-bullet, libignition-physics5-dev
Architecture: any
Version: 5.1.0+osrf-3~jammy

versus 5.1.0+osrf-2 in the config. I've just refreshed the config file and it still finds the same version for the binary ignition-physics5 packages.

@chapulina chapulina mentioned this pull request Apr 21, 2022
Merged
@chapulina
Copy link
Contributor

rosdep keys being added here:

@nuclearsandwich
Allow either osrf-2 or osrf-3 revisions for Ignition Physics.
5b8a611 
The Ignition Physics packages were revised and rebuilt for arm, bumping
the package revision.
nuclearsandwich
nuclearsandwich commented Apr 22, 2022
View reviewed changes
config/ignition_fortress_ubuntu_jammy.yaml
Package (= libignition-physics5-tpe-dev) |\
Package (= libignition-physics5-tpelib) |\
Package (= libignition-physics5-tpelib-dev) \
), ($Version (% 5.1.0+osrf-2*) | $Version (% 5.1.0+osrf-3*)) |\
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was manually changed after the scripted generator to account for a situation the script does not cover, where different platforms have different package revisions.

@nuclearsandwich nuclearsandwich merged commit f6bb401 into master Apr 22, 2022
@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/fortress-jammy-update-2022-04-14 branch April 22, 2022 18:20
@nuclearsandwich
Copy link
Contributor Author

Import jobs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero left review comments

@chapulina chapulina chapulina approved these changes

Assignees

@nuclearsandwich nuclearsandwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuclearsandwich @chapulina @j-rivero