feat(helm): Uplift to Helm v3, various requests, tag latest image #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New images are only pushed to GHCR.
When the PVC is enabled, a PV will be created and mounted to the pod instead of the emptyDir.
For pulling images from a private registry.
|
Thanks for the contribution! Before we can merge this, we need @karlskewes to sign the Salesforce.com Contributor License Agreement. |
sana-jawad
approved these changes
Jan 27, 2023
|
Thanks @karlskewes for the contribution |
|
I'm not sure what has happened with the CLA.
|
No worries I have merged it |
|
Part of #245 "On merge PR to master:" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typical practice is to tag the most recently built image with
latest. Currently the project tags withmasterand others.See: https://github.com/docker/metadata-action#latest-tag
For Helm changes, each one was tested one by one via:
helm template . | kubectl apply -f -Confirm Sloop comes up with expected change and then:
helm template . | kubectl delete -f -to remove resources from the cluster.Closes: #86 #165 #233