Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add snapshots test back #87

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

cvng
Copy link
Contributor

@cvng cvng commented Dec 18, 2023

What kind of change does this PR introduce?

follow-up for #82

What is the current behavior?

no snapshots test

What is the new behavior?

added snapshots test back in crates/parser/tests/statement_parser_test.rs

Additional context

With named tests, snapshots will be named like: [email protected] (where 1 is the statement number in the file)

@psteinroe lmk what you think about the output

Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, LGTM!

@psteinroe psteinroe merged commit 7e58c4d into supabase-community:main Dec 18, 2023
1 check passed
@cvng cvng deleted the feat/snap-test branch December 18, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants