-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rubocop, and add minitest reporters #122
Conversation
Looks like you will need to address the Rubocop error before we can see if the tests pass. |
@ehelms rubocop error is fixed now! |
@ehelms yes this worked with this simpler way. Thanks! Also now it just need rubocop version update, which needs some offenses to resolve to satisfy fully, here I have already committed this changes 1dabb8c#diff-d09ea66f8227784ff4393d88a19836f321c915ae10031d16c93d67e6283ab55fR5-R11 |
I am thinking you will need to add that Rubocop commit as commit in this PR so that the tests pass fully. |
[test smart_proxy_dynflow] |
Let's at least update Ruby 3.1 on Jenkins to latest 3.1.4 to match what Github Actions is using: theforeman/foreman-infra#1850 |
[test smart_proxy_dynflow] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR now contains the update to Ruby 3. I'd try to keep that out of this PR and keep it minimal.
A while back I submitted #104 which contains some work to update RuboCop and only utilizes the existing (passing) GH Actions. I'd recommend starting with that. In the next PRs you can add the jenkins:unit
task and then change the Ruby version matrix.
I'll also admit I really like the GH annotations for failed RuboCop rules, which you can see in my PR.
The failure is on 3.1, so I think if you do as suggested and pull out fb5cbf6 from the set of commits, that this will focus this PR on the Rubocop updates + changes to get tests running and passing. Then a dedicated Ruby 3 PR can be opened with a smaller diff and allow debugging the test failure easier. |
define the jenkins:unit rake task
@ehelms @ekohl I've moved Ruby changes from this PR to #123. |
@ehelms I'm not sure where I said it, but if it's only about Ruby 3.1 then it's not a blocker to merging it. |
cherry-picked from f91f0e2
Based on: #121