Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BashWrapper: Add 'warnFlag' parameter to allow turning off warnings #467

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Jul 4, 2023

Describe your changes

BashWrapper: Add 'warnFlag' parameter to allow turning off warnings

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • Relevant unit tests have been added

@rcannood rcannood requested a review from Grifs July 4, 2023 11:38
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 ⚠️

Comparison is base (fbcee49) 89.98% compared to head (53a82c3) 89.96%.

❗ Current head 53a82c3 differs from pull request most recent head 24184fb. Consider uploading reports for the commit 24184fb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #467      +/-   ##
===========================================
- Coverage    89.98%   89.96%   -0.03%     
===========================================
  Files           96       96              
  Lines         3146     3148       +2     
  Branches       460      454       -6     
===========================================
+ Hits          2831     2832       +1     
- Misses         315      316       +1     
Impacted Files Coverage Δ
src/main/scala/io/viash/wrapper/BashWrapper.scala 96.61% <50.00%> (-0.54%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rcannood rcannood changed the base branch from develop to render_nxf_executable July 4, 2023 11:42
@rcannood
Copy link
Member Author

rcannood commented Jul 4, 2023

Merging since it's becoming part of a different pr

@rcannood rcannood merged commit 45488fb into render_nxf_executable Jul 4, 2023
6 of 7 checks passed
@rcannood rcannood deleted the bashwrapper_warnflag branch July 4, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant